Skip to content

Conversation

Noratrieb
Copy link
Member

cc @mejrs as you wanted me to do this, does this look good and understandable?

@rustbot
Copy link
Collaborator

rustbot commented Dec 30, 2022

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 30, 2022
Copy link
Contributor

@mejrs mejrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@Noratrieb Noratrieb force-pushed the its-bugging-me-how-we-dont-have-docs branch from 1974625 to 0047e25 Compare December 30, 2022 15:48
@Noratrieb
Copy link
Member Author

small test r? @jyn514

@rustbot rustbot assigned jyn514 and unassigned davidtwco Jan 6, 2023
@jyn514
Copy link
Member

jyn514 commented Jan 6, 2023

r=me with the nit fixed, ty!

@Noratrieb
Copy link
Member Author

@bors r=jyn514 rollup

@bors
Copy link
Collaborator

bors commented Jan 6, 2023

📌 Commit 0047e25 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 7, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#106287 (Add some docs to `bug`, `span_bug` and `delay_span_bug`)
 - rust-lang#106341 (refactor: clean up `errors.rs` and `error_codes_check.rs`)
 - rust-lang#106453 (Improve include macro documentation)
 - rust-lang#106466 (Fix rustdoc source code rendering for `#[path = "../path/to/mod.rs"]` links)
 - rust-lang#106528 (Tiny formatting fix)
 - rust-lang#106534 (rustdoc-gui: Use new block syntax for define-function in goml scripts)
 - rust-lang#106542 (Add default and latest stable edition to --edition in rustc (attempt 2))

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7568c49 into rust-lang:master Jan 7, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 7, 2023
@Noratrieb Noratrieb deleted the its-bugging-me-how-we-dont-have-docs branch January 7, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants